censor values of filtered/sensitive environment variables rather than removing them from test report #4889
+12
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #4877 by @Crivella
tests will need some work, so marked as WIP
This results in filtered/censored environment variables to still be mentioned in the test report, but without their value:
Whether or not an environment variable was set could be useful information, even without knowing its value, hence this change.
We can potentially keep the current behavior for environment variables listed in
--test-report-env-filter
(i.e. actually removed them from the test report), and only use the censoring approach for "sensitive" environment variables...