Skip to content

Fix to allow pip install -e . to work seamlessly with newer pip/setuptools versions #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix to allow pip install -e . to work seamlessly with newer pip/setuptools versions #4884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e34d35
Improved import functionality to not rely on `sys.path` being set
Crivella May 16, 2025
f7eb033
lint
Crivella May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions easybuild/tools/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
import glob
import os
import re
import sys
import importlib

from string import ascii_letters, digits

from easybuild.base import fancylogger
Expand Down Expand Up @@ -132,9 +133,15 @@ def import_available_modules(namespace):
:param namespace: The namespace to import modules from.
"""
modules = []
for path in sys.path:

cand_modpath_glob = os.path.sep.join([path] + namespace.split('.') + ['*.py'])
try:
mod = importlib.import_module(namespace)
except ImportError as err:
raise EasyBuildError("import_available_modules: Failed to import %s: %s", namespace, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the semantics of import_available_modules, since no hard error was being raised before when the specified namespace didn't exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what i can see import_available_modules is always used to import all sub-modules of a specific namespace similar to doing a from NAMESPACE import *.

In particular for #4451 the failure would be obfuscated as something EB requires missing

I did not see a use in framework where this is expected to fail the import with it not being a problem.

If we really wanted to preserve the original behavior we could add a strict parameter to the call that default to False and set it to true everywhere this is used


for path in mod.__path__:

cand_modpath_glob = os.path.sep.join([path] + ['*.py'])

# if sys.path entry being considered is the empty string
# (which corresponds to Python packages/modules in current working directory being considered),
Expand Down