-
Notifications
You must be signed in to change notification settings - Fork 209
always honor keeppreviousinstall setting #4876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@smoors Hmm, it seems rather intrusive to change this behaviour, is this really the only way?
|
i agree that it's an intrusive change, but we really need a way to avoid cleaning up the installdir when building in the installdir. otherwise we have to modify each easyconfig that uses buildininstalldir. the alternative would be to add another parameter to enforce this, e.g. |
Maybe that makes more sense, yes. That way we're at least not changing existing behavior. Though it still feels a bit off somehow... |
another solution would be to only remove the contents of the installdir, but not the installdir itself. with bwrap, the installdir will appear empty anyway, so that will be very fast. |
alternative implementation with new param |
thinking more about this, i think the best solution is to add a build option to indicate that the installdir is mounted in a new namespace. that makes it clear why we are doing this, and this option can be used by the eb wrapper to install with bwrap. it will also allow fixing the Tarball easyblock, which needs |
closing in favor of #4894 |
needed for installing software in a bwrap namespace, where we bind mount the software installdir (name/version) of each software that will be installed by EB.
this in turn requires setting
keeppreviousinstall
toTrue
, because removing a bind mounted directory is not possible. we currently set this in the parse hook (would be useful to have a build option for this).EB currently hard sets
keeppreviousinstall
toFalse
ifbuildininstalldir
isTrue
, which breaks the bwrap installation, for example forecBuild
.this PR prints a big warning instead of changing
keeppreviousinstall
.see also #4110