Convert to SDK RP2350A/B determination #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2878 The SDK uses `defined(PICO_RP2350) && !PICO_RP2350A` to indicate an RP2350B chip, not the define PICO_RP2350B. Match the SDK's usage by converting from `defined(PICO_RP2350B)` to `defined(PICO_RP2350) && !PICO_RP2350A` and update the chip variants accordingly.
The *SDK*'s board definition file hardcodes a PIOC_RP2350A value for all boards, but we use the same board file for both A and B variants. Override the SDK board definition in the variant definition file.
Also ensure SDK board definition included before pins_arduino.h for clearing up redefinition errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2878
The SDK uses
defined(PICO_RP2350) && !PICO_RP2350Ato indicate an RP2350B chip, not the define PICO_RP2350B.Match the SDK's usage by converting from
defined(PICO_RP2350B)todefined(PICO_RP2350) && !PICO_RP2350Aand update the chip variants accordingly.