Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monospaced font #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aljazfrancic
Copy link
Contributor

I noticed commented out code for monospaced font usage. What gives?
I'd argue for it, to take advantage of using ljust and ensure proper "ASCII art/tables" alignment...
If done in the suggested way, all fonts in the app are adjusted, which might be overkill, and some windows might also need some tinkering with size to ensure proper visibility of all GUI elements.
Could be done on a per-widget basis, perhaps only for the text-fields?

@aljazfrancic
Copy link
Contributor Author

aljazfrancic commented Mar 4, 2025

image
Preview of how it looks on Windows with the icon from #9 as well.

@eVen-gits eVen-gits marked this pull request as ready for review March 4, 2025 07:50
@eVen-gits
Copy link
Owner

eVen-gits commented Mar 4, 2025

I believe there were some errors on some platforms where a font was missing.

As this can be adjusted on per-widget basis, I would, from aesthetics perspective, try to keep most components in regular font.

Visual improvements were also pending, so I reckon it might have been related to this. I was looking at a library called qt_material -> Feel free to uncomment lines 24 and 121-143 to preview it. There are some implications I didn't like as much, namely, it caused too much spacing between elements as well as non-functioning widget coloring (for players that are seated etc).

However, it now seems that this is already an issue on both Windows, as well as Linux which seems to be a result of a version bump in qt -> the application used to be much more condense, but it is now spaced out too much and this has to be addressed also.

I agree that the log at the bottom should be monospace, however. This can be adjusted by going to Qt Editor, or just editing the .ui file, adding a custom stylesheet entry: font-family: Monospace;. Using Monospace will also ensure that it uses whatever platform's default monospace font is.

For now, I will rectify this with per-element modifications.

Regarding other components, could you verify which elements are not monospace in Windows environment without the change?

@aljazfrancic
Copy link
Contributor Author

I'll look into it! Probably on Wednesday or Thursday...

@eVen-gits eVen-gits force-pushed the master branch 5 times, most recently from e04f72b to aeb4cba Compare March 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants