fix(onlyoffice/import-contact): library client, idempotent E2E (#67) - #74
Merged
Conversation
… email lookup E2E against live OO found two bugs in the hand-rolled client: - response.id is a number, not string (unmarshal error) - filter.json list payload has no email fields and ignores ?search=, so re-runs duplicated contacts Rewrite on the library: NewClient(GetEnvironmentCredentials()) + FindPersonByEmail (matches commonData emails) + CreatePerson + AddContactInfo. E2E verified live: run1 created=2, run2 matched=2, e2e persons cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic #66, task #67.
E2E on live OO caught: numeric response.id; filter.json ignores search and omits emails → duplicates on re-run. Rewritten on go-onlyoffice lib (FindPersonByEmail/CreatePerson/AddContactInfo). Verified live: created=2 then matched=2; e2e persons cleaned.