refactor(v1.0): P1-P7 — cleanup, MCP 5→3, tests qa→test/, config deploy→etc/, docs - #69
Closed
eSlider wants to merge 5 commits into
Closed
refactor(v1.0): P1-P7 — cleanup, MCP 5→3, tests qa→test/, config deploy→etc/, docs#69eSlider wants to merge 5 commits into
eSlider wants to merge 5 commits into
Conversation
… fixtures
- rm bin/kb/{add,index,search,watch} (deprecated; Go replacements in bin/brain)
- rm bin/serve.go (replaced by bin/brain/serve.go)
- rm bin/tools/web-search fixtures (unused test data)
- httpapi Ingest now execs bin/brain/add.go --json
- ci: drop bash -n bin/kb/search
- docs/refactor-v1.0.md: measure-first plan + A/B (epic #65)
…earch fixtures to testdata - spec.go: stats/ingest no longer exposed as MCP tools (stay OpenAPI paths) - spec_test.go: assert minimal surface (search/get/audit only) - websearch: move fixtures from bin/tools to internal/websearch/testdata - skills/brain/tools.md regenerated - docs/refactor-v1.0.md: status P1/P2/P3/P4, corrected counts
…cs rework
P5 tests taxonomy:
- qa/ → test/{system,stress}; system is the offline CI tier
- test/README.md: how to run each tier (system/stress/integration)
- historical load-test report → docs/load-test-summary-2026-08-11.md
P6 FHS config:
- deploy/{searxng,picoclaw} → etc/{searxng,picoclaw}
- compose + skill/docs paths updated; docker compose config -q clean
P7 documentation:
- README: add 'What's in 2dph today' (store, HNSW, BM25, hybrid, graph-hop,
ACID, incremental, DuckDB as auxiliary)
- docs/README index: test taxonomy + etc/ config
Epic #65, milestone v1.0.
eSlider
changed the title
- README: 'Tool layout' table (bin/{subject}/{method}.go) + explain bin/cgo
as the CGO toolchain (not CI/CD); move cli/complete.go out of table
- test/README: drop verbose stress-gate details; keep tier table + commands
- PLAN: architecture map now matches reality (no deprecated kb/, adds
test/, etc/, contacts/ci/qa/watch subjects)
…→ pkg/
Rule (D14, apply ALWAYS, also for var/ etc/): bin/{subject}/{verb}-{object}.go
singular, no trailing 's'. subject = object/system you act on; verb = action.
contacts → split by target:
- bin/contact/import.go read/normalize csv/vcf/mab → out (pure)
- bin/brain/import-contact.go upsert contacts into the brain (info leafs)
- bin/onlyoffice/import-contact.go reconcile contacts into OO CRM
- pkg/contact Contact type + parsers + Load/Dedupe/Render
Generic (no 2dph deps) internal/ → pkg/ (public reusable):
- cli, cmdbin, contact, duckstats, httpapi
- 36 import sites updated; internal/ keeps 2dph-specific (brain, chats, facts,
gitlog, mailconv, mdleaves, ocr, reasoner, websearch)
AGENTS.md documents the rule; docs/skills/PLAN paths synced.
This was referenced Aug 21, 2026
eSlider
added a commit
that referenced
this pull request
Aug 21, 2026
fix(brain/import-git): single parser, best-effort skips (#69)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.0 refactor (P1-P7)
Plan:
docs/refactor-v1.0.md, epic gitea #65. Parallel to cash-sprint #62.P1 cleanup — rm deprecated
bin/kb/,bin/serve.go; fixtures → testdata; httpapi Ingest →bin/brain/add.go.P4 MCP 5→3 — surface =
search/get/audit;stats/ingeststay OpenAPI paths.P5 tests taxonomy —
qa/→test/{system,stress};test/README.mdtiers; historical load report → docs.P6 FHS config —
deploy/→etc/{searxng,picoclaw}; compose/skills/docs updated.P7 docs — README 'What's in 2dph today'; docs index lists test taxonomy + etc/.
P2/P3 verified already lean (compose 9 services; active tools kept). mapstructure not needed (yaml.v3 struct tags). CI green (system tier).