CMake Qt config overhaul #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.31 warns about compat. for <3.10 being removed in the future. Qt6 CMake modules already require 3.16 though, so it is a good base line. CMake 3.16 was released in 2019. Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
In Qt6, there is no WebKit, which means setting APP_QT_VERSION=6 so far lead to a default CMake Error unless -DUSE_WEBENGINE was specifically set. If not cleaned up, it should be the default=off minority config. Rename USE_WEBENGINE -> USE_WEBKIT Properly invert logic where used Update docs Signed-off-by: Andreas Sturmlechner <[email protected]>
a17r
force-pushed
the
cmake-qt-improv
branch
5 times, most recently
from
99f7f6b to
ba4182b
Compare
Guard USE_KF5 and USE_WEBKIT options behind USE_QT5. Cleanup superfluous APP_QT_VERSION cmake variable Drop automagic find_package(QT NAMES) mechanism qt-aliases.cmake: Drop QT_VERSION_MAJOR, simply bail out with >=Qt-5.15 Signed-off-by: Andreas Sturmlechner <[email protected]>
Member
|
I'm leaning toward removing KDE support. While in KDE4 the application used many specific widgets, in KDE5 it only uses the about dialog and file dialog. In the next major version, I plan to integrate the browser engine via separate plugins, which will allow the use of different engines without rebuilding the application. This way, the inconveniences you mentioned will disappear by themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #58
Make WebEngine the default impl
In Qt6, there is no WebKit, which means setting APP_QT_VERSION=6 so far
lead to a default CMake Error unless -DUSE_WEBENGINE was specifically set.
If not cleaned up, it should be the default=off minority config.
Rename USE_WEBENGINE -> USE_WEBKIT
Properly invert logic where used
Update docs
Simplify and make explicit Qt5 vs. Qt6 choice
Guard USE_KF5 and USE_WEBKIT options behind USE_QT5.
Cleanup superfluous APP_QT_VERSION cmake variable
Drop automagic find_package(QT NAMES) mechanism
qt-aliases.cmake: Drop QT_VERSION_MAJOR, simply bail out with >=Qt-5.15
Please note that I can not test this with Qt5 (WebEngine|Webkit) myself any longer. I did however check that the
qt-aliases.cmakebailout logic works.