Check is blk alloced for normal volume write free blk.#158
Merged
Conversation
In crash recovery case, volume write can write to index and to disk and then crash. In this case index has stale blk ids which are not alloced, but they can be freed next time a write happens on same lba.
91f49a5 to
5259529
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
===========================================
- Coverage 61.68% 46.80% -14.89%
===========================================
Files 15 16 +1
Lines 462 1126 +664
Branches 35 541 +506
===========================================
+ Hits 285 527 +242
- Misses 158 227 +69
- Partials 19 372 +353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check is blk alloced for normal volume write free blk.
In crash recovery case, volume write can write to index
and to disk and then crash. In this case index has stale
blk ids which are not alloced, but they can be freed next
time a write happens on same lba.
Ex: write on lba=100 with blk1, add blk1 in index. crash and restart(no journal write)
write again on lba=100 with blk2, get blk1 from index to free the old blks(this is not allocated at all because it was not commited)