Skip to content

Fix perf issue #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shosseinimotlagh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix perf issue #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomeBlocksConan(ConanFile):
name = "homeblocks"
version = "5.0.6"
version = "5.0.7"

homepage = "https://github.com/eBay/HomeBlocks"
description = "Block Store built on HomeStore"
Expand Down
3 changes: 3 additions & 0 deletions src/lib/home_blks_config.fbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ table HomeBlksSettings{

// homestore dataservice chunk size;
hs_data_chunk_size_mb: uint32 = 2048;

// homestore Logstore chunk size;
hs_journal_chunk_size_mb: uint32 = 2048;
}

root_type HomeBlksSettings;
4 changes: 2 additions & 2 deletions src/lib/homeblks_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ void HomeBlocksImpl::init_homestore() {
{HS_SERVICE::META, hs_format_params{.dev_type = HSDevType::Fast, .size_pct = 9.0}},
{HS_SERVICE::LOG,
hs_format_params{
.dev_type = HSDevType::Fast, .size_pct = 45.0, .num_chunks = 0, .chunk_size = 32 * Mi}},
.dev_type = HSDevType::Fast, .size_pct = 45.0, .num_chunks = 0, .chunk_size = HB_DYNAMIC_CONFIG(hs_journal_chunk_size_mb) * Mi}},
{HS_SERVICE::INDEX,
hs_format_params{.dev_type = HSDevType::Fast,
.size_pct = 45.0,
Expand All @@ -373,7 +373,7 @@ void HomeBlocksImpl::init_homestore() {
homestore::hs()->format_and_start({
{HS_SERVICE::META, hs_format_params{.dev_type = run_on_type, .size_pct = 5.0}},
{HS_SERVICE::LOG,
hs_format_params{.dev_type = run_on_type, .size_pct = 10.0, .num_chunks = 0, .chunk_size = 32 * Mi}},
hs_format_params{.dev_type = run_on_type, .size_pct = 10.0, .num_chunks = 0, .chunk_size = HB_DYNAMIC_CONFIG(hs_journal_chunk_size_mb) * Mi}},
{HS_SERVICE::INDEX,
hs_format_params{.dev_type = run_on_type,
.size_pct = 5.0,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/volume/volume_chunk_selector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ homestore::cshared< Chunk > VolumeChunkSelector::select_chunk(homestore::blk_cou
if (*volc->m_next_chunk_index >= num_active_chunks) { *volc->m_next_chunk_index = 0; }

auto chunk = volc->m_chunks[*volc->m_next_chunk_index];
*volc->m_next_chunk_index = ((*volc->m_next_chunk_index) + 1);
if (chunk && chunk->available_blks() > 0) { return chunk->get_internal_chunk(); }
Copy link
Contributor

@sanebay sanebay Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here too.

*volc->m_next_chunk_index = ((*volc->m_next_chunk_index) + 1);
}

LOGT("Waiting to allocate more chunks active={} total={}", volc->num_active_chunks.load(),
Expand Down
Loading