-
Notifications
You must be signed in to change notification settings - Fork 194
Add peer-to-peer metrics tracker #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djeebus
wants to merge
20
commits into
main
Choose a base branch
from
joint-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm going to pull a piece out to its own PR, and reopen when that's merged. |
this allows us to put sandbox-specific code here, to execute on insert, on delete, etc
2e39e0f to
5bababb
Compare
# Conflicts: # packages/orchestrator/internal/server/main.go # packages/orchestrator/internal/server/sandboxes_test.go # packages/orchestrator/internal/service/service_info.go # packages/orchestrator/main.go
# Conflicts: # packages/orchestrator/internal/cfg/model.go
sitole
reviewed
Oct 21, 2025
sitole
reviewed
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates metrics into a single struct that does a few things:
{pid}.jsonIt also creates
server.Limiterfor checking starting and running limits.Note
Introduces a shared-state manager that aggregates sandbox allocations across processes via PID JSON files and integrates a limiter to cap starting/running sandboxes, wiring both into server and service info paths.
internal/sharedstatewithManagerthat writes self allocations to{pid}.json, watches directory viafsnotify, and aggregatesAllocationsacross processes.sandboxesmap viaSubscribe; exposeTotalAllocated()andTotalRunningCount().internal/sharedstate/tracker_test.go.server.Limiterto enforce max running (viafeatureflags.MaxSandboxesPerNode) and max starting per node; replace semaphore logic inserverwithsandboxLimiterand error handling.internal/service/service_info.go: switch from iterating localsandboxesto usingsharedstate.Managerfor CPU/memory/disk and running counts.SHARED_STATE_DIRECTORY,SHARED_STATE_WRITE_INTERVAL,MAX_STARTING_INSTANCEStocfg.Config.main.go: instantiate and runsharedstate.Manager; pass toInfoServiceandserver.New; createserver.NewLimiter.github.com/fsnotify/fsnotifytogo.mod/go.sum.Written by Cursor Bugbot for commit 835ee09. This will update automatically on new commits. Configure here.