Refactor: Dashboard routing / sidebar layout, to support team settings tabbar #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed routes + clean up outdated routing and config structures
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Removed outdated test cases from `dashboard-routes.test.ts` to streamline tests and focus on relevant functionality. - Deleted unused `dashboard-tabs.test.tsx` file to reduce clutter in the test suite.
ben-fornefeld
changed the title
…ut components - Deleted `dashboard-routes.test.ts` and `dashboard-routes.ts` to eliminate obsolete routing configurations and tests. - Updated `DashboardLayout` and related components to simplify structure by removing unnecessary props and enhancing layout consistency. - Refactored tab components in sandboxes and settings to utilize a more streamlined approach with `DashboardTabs` and `DashboardTab` for better maintainability.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Adjusted positioning and margin styles in the dashboard header and tabs for better alignment. - Enhanced the DashboardTabs component with additional class names for improved spacing. - Updated icon sizes in the settings layout for a more uniform appearance. - Refined the layout wrapper to utilize dynamic viewport height for better responsiveness. - Modified theme variables for protected navigation height to ensure consistent styling across components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of upcoming features and in accordance to our Figma design, this PR refactors the following:
/dashboard/$teamId/teamwas split to/dashboard/$teamId/membersand/dashboard/$teamId/settings?tab=general/dashboard/$teamId/keys->/dashboard/$teamId/settings?tab=keysNew Sidebar Layout
New Settings Route
Note
Splits team settings into Members and Settings (General/Keys), introduces reusable DashboardTabs, updates sidebar/routes/headers, and refactors members/keys pages to use params-based team resolution.
teamintomembersandsettings?tab=general; movedkeystosettings?tab=keyswith new parallel routes and layout.sandboxesandsettingsto support parallel route slots./dashboard/route.tstab mapping (addsmembers,settings), sign-in flow, and default team handling.configs/sidebar.ts; links now includeMembersandSettings(replacingTeam/API Keys).PROTECTED_URLSwithSETTINGS(team, tab)andMEMBERS; tweakedSANDBOXEStab query.ui/dashboard-tabsand refactored sandboxes/settings/sandbox-detail to use it; removed old sandbox tabs.getDashboardPageConfigwithgetDashboardLayoutConfig; updated header styles and wrapper behavior.theme.css.paramsand resolveteamIdserver-side; updated create key dialog to use selected team.jsxset topreserve.Written by Cursor Bugbot for commit 60912ad. This will update automatically on new commits. Configure here.