Patch: Re-enable dashboard feedback survey popover #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schemas - Reformatted `tsconfig.json` for better readability by aligning array elements. - Changed JSX setting from `react-jsx` to `preserve` in `tsconfig.json`. - Updated Zod validation in `get-api-keys.ts` and `key-actions.ts` to use `z.uuid()` for team and API key IDs, enhancing error handling. - Improved type inference in `formatErrors` function in `env.ts` for better type safety.
…kage.json and bun.lock - Updated `@supabase/ssr` from `^0.5.2` to `^0.7.0`. - Upgraded `@supabase/supabase-js` from `^2.48.1` to `^2.57.4`. - Changed `zod` version from `^3.24.1` to `^4.1.11`. - Updated `@supabase/functions-js` from `2.4.5` to `2.4.6`, `@supabase/postgrest-js` from `1.21.3` to `1.21.4`, and `@supabase/realtime-js` from `2.15.4` to `2.15.5`. - Adjusted `@supabase/storage-js` from `2.11.0` to `2.12.1` and `cookie` from `0.7.2` to `1.0.2` in lock files.
- Upgraded `posthog-js` and `@posthog/core` to version `1.268.1` and `1.1.0` respectively in `package.json` and `bun.lock`. - Refactored Next.js rewrites to use `/ph-proxy` instead of `/ingest` for PostHog API calls. - Simplified `DashboardLayoutView` component by removing unnecessary props. - Enhanced `PostHogProvider` to include validation for `NEXT_PUBLIC_POSTHOG_HOST`. - Implemented a new `DashboardSurveyPopoverResolver` to conditionally render the survey popover based on environment variables. - Updated sidebar to include the survey popover for user feedback collection.
- Downgraded `@supabase/ssr` from `^0.7.0` to `^0.5.2` and `@supabase/supabase-js` from `^2.57.4` to `^2.48.1` in `package.json` and `bun.lock`. - Updated `cookie` dependency from `1.0.2` to `0.7.2`. - Refactored Zod schema merging in `env.ts` to use `merge` instead of `extend` for better clarity.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Modified the `DashboardSurveyPopover` button styles for improved hover effects and layout. - Adjusted the `StartRateChartClient` component by removing an unnecessary border class. - Enhanced the `DashboardSidebarFooter` structure for better organization and added a separate survey menu item. - Introduced a new CSS variable for the protected status bar height in `theme.css`.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Updated the `DashboardSurveyPopover` to accept a trigger prop for better flexibility. - Refactored the `DashboardSidebarFooter` to integrate the survey popover with improved styling and layout. - Adjusted the `general-analytics-collector` to ensure proper PostHog reset functionality. - Modified CSS variables for sidebar width to improve responsiveness.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakubno
requested changes
Sep 25, 2025
src/features/dashboard/sandboxes/monitoring/charts/start-rate-chart.client.tsx
Show resolved
Hide resolved
…erministic after ph init
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
https://zod.dev/v4/changelog?id=deprecates-message |
- Replaced deprecated Zod string validation for email and UUID with the new syntax. - Removed the unused `.eslintignore` file to clean up the project structure. - Enhanced various schemas across the application for consistency and clarity.
jakubno
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #128 we disabled the dashboard feedback survey popover, because it caused problems. The following applied, seems to have fixed this issue:
/ingestto/ph-proxyadvanced_enable_surveysto posthog init, to ensure relevant surveys are not hidden behind ph feature flagsNew - Closed:
New - Open
Note
Re-enables the dashboard feedback survey using a new PostHog provider and /ph-proxy, while migrating validation to zod v4 and updating related deps/config.
src/features/posthog-provider.tsxand wraps app withPostHogProviderto initialize PostHog (surveys enabled) and exposedashboardFeedbackSurvey.DashboardSurveyPopoverto use provider, accept custom trigger, and capture show/dismiss/submit events; integrates a Feedback button in the sidebar footer./ingestto/ph-proxyand updates middleware matcher to excludeph-proxy.posthog-jsand@posthog/core.z.string().email(),z.string().url(),z.string().uuid()withz.email(),z.url(),z.uuid()across server/client schemas (auth, billing, keys, sandboxes, team, env, user, etc.).zod@^4andzod-form-data@^3.teamIdOrSlugprops from dashboard layout/header.sidebarMenuButtonVariantsand adds variants (incl.inverted); minor styling tweaks (e.g., remove border instart-rate-chart).next.config.mjsrewrites updated;tsconfig.jsonswitches JSX topreserve.package.jsondependency bumps (Supabase libs, PostHog).Written by Cursor Bugbot for commit 7a5331b. This will update automatically on new commits. Configure here.