Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for retain plugins #142

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

rhierlmeier
Copy link

With this PR I improved the logging of the retainsPlugins processing. It produces also a warning when in the retainPlugin-list and unknown execution is specified. Helps to avoid configuration errors.

In additional I changed the expected format for the retainsPlugins elements.
It is now :[@executionId] according to the Maven standards.
The old format :[:executionId] is normally targeting a Maven goal and not an execution.

Hierlmeier, Richard added 4 commits April 21, 2023 14:50
@glimmerveen
Copy link
Contributor

Good suggestion to change the syntax to better align with the Maven notation conventions.

Just a small remark on the check to avoid configuration errors: it will result in "false warnings" when someone wants to rely on the inheritance of configuration: when one wants to configure retainPlugin in a parent pom, that only applies to some of the childs, the other child modules would produce a warning. This can of course can be addressed by only configuring this retainPlugin on the level where the plugins are actually executed, but that would result in some duplication of configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants