Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trade status view #340

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Trade status view #340

merged 14 commits into from
Jan 23, 2025

Conversation

ruixhuang
Copy link
Contributor

Header Header
Simulator Screenshot - iPhone 16 Pro - 2025-01-22 at 15 47 38 Simulator Screenshot - iPhone 16 Pro - 2025-01-22 at 15 47 31

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang
Buying Power simplified
3789f7d
@ruixhuang
Market specific buying power
9421764
@ruixhuang
Margin Risk
c70a770
@ruixhuang
Fees
6a7ba34
@ruixhuang
Trade status UI
ae3e32c
@ruixhuang
WIP
8b2fc3f
@ruixhuang
Submission
0eb164a
@ruixhuang
Modal sheet
04af6ad
@ruixhuang
Fixing notification text theming
5637a0f
@ruixhuang
Disabled trade button update
f1ebdbe
@ruixhuang
Merge branch 'develop' into feature/sui_14
d0cec1b 
# Conflicts:
#	dydx/dydxPresenters/dydxPresenters.xcodeproj/project.pbxproj
#	dydx/dydxPresenters/dydxPresenters/_v4/SimpleUI/Trade/TradeInput/components/dydxSimpleUIFeesViewPresenter.swift
#	dydx/dydxPresenters/dydxPresenters/_v4/SimpleUI/Trade/TradeInput/dydxSimpleUITradeInputViewBuilder.swift
#	dydx/dydxViews/dydxViews.xcodeproj/project.pbxproj
#	dydx/dydxViews/dydxViews/_v4/SimpleUI/Trade/TradeInput/dydxSimpleUITradeInputView.swift
@ruixhuang
Fix position buying power display
2abf585
@ruixhuang
Loading dots
10f5623
@ruixhuang
Loading dots
c3d5e90
@ruixhuang ruixhuang marked this pull request as ready for review January 22, 2025 23:58
@ruixhuang ruixhuang merged commit e5ab5ef into develop Jan 23, 2025
5 checks passed
@ruixhuang ruixhuang deleted the feature/sui_14 branch January 23, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @tyleroooo