S3 to Azure backup #236
Draft
S3 to Azure backup #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stretch96
commented
Apr 11, 2025
Stretch96
commented
- Creates a scheduled task, which runs the RDS tooling image, to copy an S3 bucket to an Azure container
- Environment variables are added to the task definition, to authenticate with Azure
Stretch96
force-pushed
the
s3-to-azure-backup
branch
from
9ec72ba to
0925ffe
Compare
DrizzlyOwl
reviewed
Apr 11, 2025
| infrastructure_s3_to_azure_backup_command = join( | ||
| " && ", | ||
| [ | ||
| for obj in local.infrastructure_s3_to_azure_backup : "s3-to-azure -d \"${obj["s3_bucket_name"]}\" -d \"${obj["azure_container_name"]}\"" |
There was a problem hiding this comment.
this should be -s for source and -d for destination
| } | ||
|
|
||
| variable "infrastructure_s3_to_azure_backup_azure_spa_application_id" { | ||
| description = "Azure service principle app (spa) application id for the S3 to Azure backups" |
There was a problem hiding this comment.
principal not principle
|
|
||
| variable "infrastructure_s3_to_azure_backup" { | ||
| description = <<EOT | ||
| List of objects, defining S3 bucket name and Azure container name, along with Azure credentials |
There was a problem hiding this comment.
azure credentials seem to be separate vars so does the description need amending here?
s3-azure-backup-scheduled-task.tf
Outdated
| resource "aws_cloudwatch_event_target" "infrastructure_s3_to_azure_backup_scheduled_task" { | ||
| count = local.infrastructure_s3_to_azure_backup_cron_expression != "" ? 1 : 0 | ||
|
|
||
| target_id = "${local.resource_prefix}-s3-to-azure-backup-${each.key}" |
There was a problem hiding this comment.
each.key is used here but you are in a count loop not a for_each loop. would each.key just be the index number here?
Stretch96
force-pushed
the
s3-to-azure-backup
branch
from
0925ffe to
214e05f
Compare
* Creates a scheduled task, which runs the RDS tooling image, to copy an S3 bucket to an Azure container * Environment variables are added to the task definition, to authenticate with Azure
Stretch96
force-pushed
the
s3-to-azure-backup
branch
from
214e05f to
f966ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.