Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new bookings system #653

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add the new bookings system #653

wants to merge 3 commits into from

Conversation

ilgazer
Copy link
Contributor

@ilgazer ilgazer commented Jan 12, 2025

I added the new bookings system as an iframe, and reverted all of the booking-related links to their old state.

Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2025

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: afdd09d
Status: ✅  Deploy successful!
Preview URL: https://286bd799.dwhdelft-nl.pages.dev
Branch Preview URL: https://add-new-bookings.dwhdelft-nl.pages.dev

View logs

Copy link

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: afdd09d
Status: ✅  Deploy successful!
Preview URL: https://9ec0c5d1.dwhdelft-nl-u1a.pages.dev
Branch Preview URL: https://add-new-bookings.dwhdelft-nl-u1a.pages.dev

View logs

@ilgazer ilgazer requested review from thomcsmits and vanadie January 12, 2025 16:27
@casperboone casperboone self-requested a review January 12, 2025 16:44
Copy link
Member

@thomcsmits thomcsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice new system!

Two things I quickly found:

  • Visually, this white triangle isn't fantastic. Maybe we can make this also the same purple?
    image
  • Am I correct that the booking system is only in English? On the Dutch page, the iFrame is still in English

@ilgazer
Copy link
Contributor Author

ilgazer commented Feb 5, 2025

What do you mean by the white triangle? Also, I forgot to add dutch support but can do it without much difficulty. Also, do we want a way to put separate english and dutch title and descriptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants