Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixup tweaks #643

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Mixup tweaks #643

merged 5 commits into from
Jan 4, 2025

Conversation

casperboone
Copy link
Member

before after
image image
image image
image image
image image
image image

thomcsmits
thomcsmits requested changes Jan 4, 2025
View reviewed changes
Copy link
Member

@thomcsmits thomcsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Aesthetically pleasing:) I like the cards!
Also nice to add the time.

I just find this gray here to have too little contrast with the background, it's very hard to read:
image

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025 •
edited
Loading

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0cb9eba
Status: ✅  Deploy successful!
Preview URL: https://9bc96827.dwhdelft-nl-u1a.pages.dev
Branch Preview URL: https://mixup-tweaks.dwhdelft-nl-u1a.pages.dev

View logs

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025 •
edited
Loading

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0cb9eba
Status: ✅  Deploy successful!
Preview URL: https://3d718b01.dwhdelft-nl.pages.dev
Branch Preview URL: https://mixup-tweaks.dwhdelft-nl.pages.dev

View logs

@casperboone casperboone requested a review from thomcsmits January 4, 2025 16:26
@casperboone
Copy link
Member Author

merging this for now because I want to do a bigger change, please still comment if something's up

@casperboone casperboone merged commit 265afc3 into main Jan 4, 2025
3 checks passed
@casperboone casperboone deleted the mixup-tweaks branch January 4, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARBaart ARBaart Awaiting requested review from ARBaart

@laurensWe laurensWe Awaiting requested review from laurensWe

@thomcsmits thomcsmits Awaiting requested review from thomcsmits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperboone @thomcsmits