Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: positioning responsive icon #637

Merged
merged 4 commits into from
Jan 4, 2025
Merged

bugfix: positioning responsive icon #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3068bdb
working option1
sharwinbobde Dec 17, 2024
c666797
working option2
sharwinbobde Dec 17, 2024
b50ef1d
changed mimiced for outsite.nl
sharwinbobde Dec 19, 2024
ac8ae1c
panda rotational correction
sharwinbobde Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dwhdelft.nl/components/pages/home/Intro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const barOpeningHours = openingHours.value.events.find((event) => event.day.en =
/>
<p v-if="barOpeningHours.announcement" class="mt-3 mb-4 text-brand-500" v-text="tt(barOpeningHours.announcement)" />
<PagesHomeInvite
class="my-8 md:my-4"
class="my-8"
:announcement="t('invite.announcement')"
:time="t('invite.time', [barOpeningHours.start_time])"
/>
Expand Down
2 changes: 1 addition & 1 deletion dwhdelft.nl/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const instagramChannels = [
</LayoutHeader>

<section class="overflow-x-hidden">
<div class="container mx-auto pt-12 pb-24 md:flex">
<div class="container mx-auto pt-12 pb-28 md:flex">
<div class="flex-1 px-4 lg:pr-32">
<PagesHomeIntro />
</div>
Expand Down
2 changes: 1 addition & 1 deletion outsite.nl/components/pages/home/Intro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const barOpeningHours = openingHours.value.events.find((event) => event.day.en =
/>
<p v-if="barOpeningHours.announcement" class="mt-3 mb-4 text-brand-500" v-text="tt(barOpeningHours.announcement)" />
<PagesHomeInvite
class="my-8 md:my-0"
class="my-8"
:announcement="t('invite.announcement')"
:time="t('invite.time', [barOpeningHours.start_time])"
/>
Expand Down
4 changes: 2 additions & 2 deletions outsite.nl/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ const instagramChannels = [
</LayoutHeader>

<section class="overflow-x-hidden overflow-y-visible pt-48 -mt-48 -mb-40">
<div class="container mx-auto pt-12 sm:pt-16 pb-24 md:flex md:justify-between">
<div class="container mx-auto pt-12 sm:pt-16 pb-28 md:flex md:justify-between">
<div class="md:w-1/2 px-4">
<PagesHomeIntro />
</div>
<div class="md:w-2/5 overflow-hidden md:overflow-visible relative">
<Panda class="relative md:absolute bottom-0 left-5 w-full" />
<Panda class="relative md:absolute bottom-0 left-5 w-full rotate-[12deg]" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of rotating the panda, I think it's better to fix the positioning for 430px-768px screens (not necessarily with such a specific target). Just to not change the visual appearance of the panda ;) 🐼

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I tried shifting the panda down before rotating it. It looked a bit odd, like just a stub peeking out. I wasn't happy with that, so I said just aligned the image with the diagonal stripe; it was more consistent, looked similar at all resolutions, and we see more of the panda.

Ill try putting up a screenshot with the repositioned panda for comparison later today.

</div>
</div>
</section>
Expand Down
Loading