Using generators internally + refactoring flow #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to add more async logic here (such as working with the cache) I've decided to change how this module is structured internally. Primarilly, it now uses generators instead of normal callbacks. I'm using `unyield` so the API _technically_ hasn't changed, although it does now require the `--harmony-generators` flag since it is using generators under the hood. I've also removed `options.retries`, as that is an internal detail that doesn't really need to be configurable at this time.
| */ | ||
|
|
||
| function* get(token, parts, attempts) { | ||
| var url = 'https://api.github.com/' + path.join.apply(path, parts); |
There was a problem hiding this comment.
will path.join() do weird stuff on windows (e.g. "https://api.github.com/foo\\bar\\")?
There was a problem hiding this comment.
haha possibly related? duojs/duo#481
There was a problem hiding this comment.
Oh snap... you're probably right. We should use url.resolve instead anyways. Good catch.
There was a problem hiding this comment.
I don't think this is directly related to that issue. That's probably somewhere in duo-pack, if I were to guess.
But it's still a good idea here to use url.resolve() w/o path.join() at all.
|
lgtm :) |
|
works for me! |
dominicbarnes
added a commit
that referenced
this pull request
Jul 10, 2015
Using generators internally + refactoring flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to add more async logic here (such as working with the cache) I've decided to change how this module is structured internally. Primarilly, it now uses generators instead of normal callbacks.
I'm using
unyieldso the API technically hasn't changed, although it does now require the--harmony-generatorsflag since it is using generators under the hood. I've also removedoptions.retries, as that is an internal detail that doesn't really need to be configurable at this time.The main changes here:
index.jstolib/resolve.jsunyieldto retain same high-level APIdebugoutput more consistent and easy to follow even in parallellib/github.js)I'm going to start working on a branch right away that leverages the new cache to store the results of Github API calls. (which should cut down on the number of API calls counting towards the limit)