using url.resolve instead of path.join

duojs · Jul 10, 2015 · 0841cd4 · 0841cd4
1 parent 17dd652
commit 0841cd4
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/github.js b/lib/github.js
@@ -6,7 +6,7 @@
 
 var debug = require('debug')('duo:gh-resolve:github');
 var request = require('co-request');
-var path = require('path');
+var url = require('url');
 
 
 /**
@@ -53,18 +53,18 @@ exports.branch = function* (token, options) {
  */
 
 function* get(token, parts, attempts) {
-  var url = 'https://api.github.com/' + path.join.apply(path, parts);
-  debug('--> GET %s', url);
+  var uri = url.resolve('https://api.github.com/', parts.join('/'));
+  debug('--> GET %s', uri);
 
   var res = yield request({
-    url: url,
+    url: uri,
     qs: { access_token: token },
     headers: { 'User-Agent': 'duo:gh-resolve' },
     followRedirects: true,
     json: true
   });
 
-  debug('<-- %s %s', res.statusCode, url);
+  debug('<-- %s %s', res.statusCode, uri);
   rateLimit(res.headers);
 
   if (isError(res.statusCode)) {