Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Make nodePort configurable for NodePort service type #962

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat(helm): Make nodePort configurable for NodePort service type #962

merged 1 commit into from
Oct 23, 2024

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Oct 22, 2024

When using NodePort as the service.type in the helm chart, there is no possibility to fix the port number.

This introduces the conditional for the helm chart.

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dunglas dunglas merged commit 6c511ee into dunglas:main Oct 23, 2024
13 checks passed
@dunglas
Copy link
Owner

dunglas commented Oct 23, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bebehei @CLAassistant @dunglas