Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed subscriptions API filtering by topics #834

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: Fixed subscriptions API filtering by topics #834

merged 1 commit into from
Dec 4, 2023

Conversation

itodor
Copy link
Contributor

@itodor itodor commented Nov 16, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@itodor itodor mentioned this pull request Nov 16, 2023
Closed
dunglas
dunglas approved these changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for the fix.

Could you sign the CLA please?

@itodor itodor force-pushed the fix/subscriptionsFiltering branch from 0759ca8 to 54bb09a Compare November 21, 2023 09:34
@itodor
Copy link
Contributor Author

itodor commented Nov 21, 2023

Thanks, signed, there was a email mismatch between account email and commit email but now it's fixed

@dunglas dunglas force-pushed the fix/subscriptionsFiltering branch from 54bb09a to 696b84d Compare December 4, 2023 21:33
@dunglas dunglas merged commit 3792c93 into dunglas:main Dec 4, 2023
7 checks passed
@dunglas
Copy link
Owner

dunglas commented Dec 4, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itodor @CLAassistant @dunglas