Skip to content

Conversation

ItzTJSV2
Copy link

@ItzTJSV2 ItzTJSV2 commented Jul 7, 2025

Should hopefully be able to close #214.

Just changed how items were being arranged via centering and adding some minor padding to ensure it looks the same.

@Lordfirespeed
Copy link
Member

Lordfirespeed commented Jul 7, 2025

The padding changes lead to text flowing behind the carousel controls on mobile

image

I do prefer the text taking up more of the screen's width. Maybe on mobile devices we should style the carousel controls to be less intrusive; maybe semicircles at edges of screen...

@ItzTJSV2
Copy link
Author

ItzTJSV2 commented Jul 7, 2025

Check new commit, readded size-full and removed paddings in favour of margins in the inner-element. Fixed the bottom padding issue with an included padded div below. Semi-circle change to do

Copy link
Author

@ItzTJSV2 ItzTJSV2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned the buttons to hit the edge of the screen while making the text allowed to go wider. Meant to be done with changes to web-components' "carousel-previous" and "carousel-next" to be "absolute h-8 w-4 rounded-r-full" and "absolute h-8 w-4 rounded-l-full" respective.

Although, based off my testing this may make the circles rather small on smaller/tighter mobile screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/x 'about' slide: text runs off the end of the screen and is unscrollable
2 participants