Don't crash on background worker connection error #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you had an invalid MotherDuck token you would get into a crash-loop, because the background worker would fail to connect and crash Postgres. This fixes that by catching all exceptions thrown by C++ functions in the background worker. Resolves #622
mkaruza
approved these changes
Feb 26, 2025
JelteF
added a commit
that referenced
this pull request
Feb 26, 2025
With #630 I accidentally broke MotherDuck support. I had only tested that it would not crash with an incorrect MotherDuck token, but I had not confirmed that a correct one would continue to work correctly. This fixes that. The reason that this broke was that we would hold a raw pointer to a unique_ptr that was already out of scope. This fixes that by creating the unique_ptr in the correct scope again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had an invalid MotherDuck token you would get into a crash-loop,
because the background worker would fail to connect and crash Postgres.
This fixes that by catching all exceptions thrown by C++ functions in
the background worker.
Resolves #622