Add support for url_style secret parameter #621
Merged
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Feb 24, 2025
JelteF
added a commit
that referenced
this pull request
Feb 24, 2025
We need the necessary boilerplate for 0.4.0 development. In #621 the contributor had problems understanding where to add their new SQL. This should solve that problem.
Co-authored-by: Jelte Fennema-Nio <[email protected]>
JelteF
approved these changes
Feb 26, 2025
JelteF
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
URL_STYLEsecret parameter.Setting this parameter to
pathallows connecting to minio S3 storage.Setting no value keeps the default behaviour and does not break the current behaviour.
This feature is requested in #151 and #207.
The code is working in my test environment.
As this is my first contribution to this project I would appreciate any feedback. Thank you for this awesome tool.