add function guard

duckdb · Feb 26, 2025 · e3a22bb · e3a22bb
1 parent f8eb069
commit e3a22bb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/pgduckdb_types.cpp b/src/pgduckdb_types.cpp
@@ -340,9 +340,12 @@ ConvertNumericDatum(const duckdb::Value &value) {
 
 	// Special handle duckdb VARINT type.
 	if (value.type().id() == duckdb::LogicalTypeId::VARINT) {
-		std::string value_str = value.ToString();
-		Datum pg_numeric = DirectFunctionCall3(numeric_in, CStringGetDatum(value_str.c_str()),
-		                                       ObjectIdGetDatum(InvalidOid), Int32GetDatum(-1));
+		// The performant way to handle the translation is to parse VARINT out, here we leverage string conversion and
+		// parsing mainly for code simplicity.
+		const std::string value_str = value.ToString();
+		const Datum pg_numeric = PostgresFunctionGuard(
+		    DirectFunctionCall3(numeric_in, /*str=*/CStringGetDatum(value_str.c_str()),
+		                        /*typelem=*/ObjectIdGetDatum(InvalidOid), /*typmod=*/Int32GetDatum(-1)));
 		return pg_numeric;
 	}