Skip to content

Run dstack server on the asyncio event loop #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterschmidt85 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run dstack server on the asyncio event loop #4363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dstack/_internal/cli/commands/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ def _command(self, args: argparse.Namespace):
reload_excludes=reload_excludes,
log_level=uvicorn_log_level,
workers=1,
# uvloop spawns subprocesses with fork(), which can hang the server (#4362).
loop="asyncio",
)

def _configure_logging(self) -> None:
Expand Down
12 changes: 12 additions & 0 deletions src/tests/_internal/cli/commands/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import os
from unittest.mock import patch

from dstack._internal.cli.commands import server
from tests._internal.cli.common import run_dstack_cli


class TestServerCommand:
def test_runs_uvicorn_on_asyncio_loop(self):
with patch.dict(os.environ), patch.object(server.uvicorn, "run") as uvicorn_run:
assert run_dstack_cli(["server"]) == 0
assert uvicorn_run.call_args.kwargs["loop"] == "asyncio"
Loading