Fix case-sensitive fleet and run spec intersection - #4215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fleet spec and a run spec were intersected case-sensitively, so a fleet declaring
gpu: mi300xand a run requestinggpu: MI300Xproduced an empty GPU name list that matches nothing. The run then got no backend offers at all - only offers from instances that already existed in the fleet - whiledstack offer, which ignores fleets, kept returning them.compute_capabilitywithmaxrather thanmin, since it is a lower bound and the stricter of the two must win.Fixes #4214.
AI assistance: written with Claude Code.