[ORAM batch handling] oramExecutor with grpc queuing for batches #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haseeb1399
reviewed
Feb 22, 2025
pkg/oramExecutor/oramExecutor.go
Outdated
| }) | ||
| } | ||
| e.opCond.Signal() // Notify batch processor | ||
| e.opMutex.Unlock() |
There was a problem hiding this comment.
You can use a channel as a channel (maybe even a buffered channel) instead of using a list. I think each executor's queue in bacher is a channel and not a list. You can keep checking the size of the channel to know when its upto batch size.
nachiketsrao
force-pushed
the
oram-batcher
branch
from
42e5485 to
e2bfaf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Scale 2: