Skip to content

Remove external mock dependency - #598

Merged
AndreyVMarkelov merged 2 commits into
dropbox:mainfrom
s-t-e-v-e-n-k:remove-mock
Oct 1, 2026
Merged

AndreyVMarkelov merged 2 commits into
dropbox:mainfrom
s-t-e-v-e-n-k:remove-mock

Conversation

@s-t-e-v-e-n-k

Copy link
Copy Markdown
Contributor

Python 3.4 added mock to the unittest module, and we support a much newer version than that, so drop the requirement.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

Python 3.4 added mock to the unittest module, and we support a much
newer version than that, so drop the requirement.
@CLAassistant

CLAassistant commented Sep 29, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AndreyVMarkelov
❌ s-t-e-v-e-n-k
You have signed the CLA already but the status is still pending? Let us recheck it.

@ineil-dbx

Copy link
Copy Markdown

Hi @s-t-e-v-e-n-k , Thanks for submitting the pull request! I've shared it with our engineering team for review. We'll let you know once we have an update.

@AndreyVMarkelov
AndreyVMarkelov merged commit 258901f into dropbox:main Oct 1, 2026
21 of 22 checks passed
@s-t-e-v-e-n-k
s-t-e-v-e-n-k deleted the remove-mock branch October 1, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants