Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git timeout #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

git timeout #53

wants to merge 1 commit into from

Conversation

sdarwin
Copy link

@sdarwin sdarwin commented Mar 27, 2025

Hi,
I have observed the initial git fetch to hang in certain situations, specifically IBM Cloud. That happens even with the retries option in place. It's freezing indefinitely.

Logically, if git fetch were unresponsive for a certain amount of time wouldn't it make sense to retry?

Yet that functionality has been missing.

I am now able to confirm, this modification does fix the issue.

Other details:

  • Adding a 'sleep' between retries, since if there is a very quick failure, you'd want to wait.
  • Setting conservative default values (5 retries, 300 second timeout). Both retries and timeouts are very useful. Is there a counter-argument to not enabling them by default?

This would need to be done: https://github.com/drone-runners/drone-runner-docker/pull/44/files

Open to any suggestions.

60 second timeout seems better, the reason for 300s is to be very sure it doesn't affect any large repositories. Could be put back to 60 if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant