Make HttpAppFrameworkImpl::quit() safe #2247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It is possible to call
HttpAppFrameworkImpl::quit()
2 times in a row directly or in the default signal handler.Calling such code:
Execues double calling of such code in internal lambda:
listenerManagerPtr_->stopListening(); listenerManagerPtr_.reset();
And it leads to undefined behavior.
Fix:
Atomically check and set
running_
flag earlier before queuing the lambda that resets pointers.