Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add StreamReader cancel read steam #2232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add StreamReader cancel read steam #2232

wants to merge 1 commit into from

Conversation

afx919
Copy link

@afx919 afx919 commented Dec 13, 2024

dataCb增加bool返回值用于取消接收

@an-tao an-tao requested a review from hwc0919 December 13, 2024 10:05
@hwc0919
Copy link
Member

hwc0919 commented Dec 13, 2024

方向不对。 MultipartStreamParser 是用来解析字节流的，它不应该关心其他事情。这个修改直接打穿了所有的抽象层，完全不能接受。

这个修改并没有中断请求体的接收，也没有给客户端相应的应答。而且 MultipartStreamReader 只是 RequestStreamReader 的一个参考实现，只修改它是没有意义的。

正确的思路应该是给 RequestStreamReader 添加一个 abort 方法。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwc0919 hwc0919 Awaiting requested review from hwc0919

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afx919 @hwc0919