Add setAutoCommit method to the Transaction class #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marty1885
reviewed
Apr 2, 2023
| thisPtr->commitCallback_(true); | ||
| } | ||
| }, | ||
| [thisPtr](const std::exception_ptr &) { |
There was a problem hiding this comment.
Since this is the last place we used thisPtr. Can move move it to avid a copy?
Comment on lines
+44
to
+45
| commitCb = std::move(commitCallback_), | ||
| autoCommit = autoCommit_]() { |
There was a problem hiding this comment.
UB if the user manually commits then auto commit happens. Could the following happen?
auto t = db->newTransactionCoro();
...
t->commit();
// now `t` destructs. Calls auto commit. We try to move an already moved variable.| { | ||
| commitCb(true); | ||
| } | ||
| }, | ||
| [commitCb](const std::exception_ptr &ePtr) { | ||
| [commitCb, autoCommit](const std::exception_ptr &ePtr) { |
There was a problem hiding this comment.
Since this is the last time we use commitCb. We can move it instead of making a copy.
There was a problem hiding this comment.
Are the arguments evaluated in left-to-right order? If not, we can not use move.
hwc0919
reviewed
Nov 11, 2024
| LOG_TRACE << "Transaction committed!"; | ||
| if (commitCb) | ||
| if (autoCommit && commitCb) | ||
| { | ||
| commitCb(true); | ||
| } |
There was a problem hiding this comment.
should be commitCb(autoCommit) ?
same in execption callback
I prefer not using this commitCb. It's confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1386 #1428