Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBU calculators #72

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Add IBU calculators #72

merged 5 commits into from
Oct 9, 2020

Conversation

mlatief
Copy link
Collaborator

@mlatief mlatief commented Oct 7, 2020

Calculate total IBU for hops additions, and weight of bittering hops required for target IBU.

Part of #24

Copy link
Owner

@drodil drodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Missing CLI command to run this (not sure how it's possible to add multiple hops from there though).. but maybe something for next PR

@mlatief
Copy link
Collaborator Author

mlatief commented Oct 7, 2020

working on some CLI proof-of-concept, but facing exactly that issue, especially with hops additions having more than one parameter. So decided at least to push the calculators first for review.

@mlatief mlatief marked this pull request as draft October 7, 2020 18:33
@drodil
Copy link
Owner

drodil commented Oct 8, 2020

See #75 how hops could be stored in JSON as well, it's pretty nice way :)

@mlatief mlatief marked this pull request as ready for review October 9, 2020 00:08
@mlatief mlatief merged commit 9c452f4 into master Oct 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the ibu branch October 9, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants