Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure Blob Storage as a storage engine for attachments #255

Merged
merged 12 commits into from
Jan 7, 2025
Merged

Add Azure Blob Storage as a storage engine for attachments #255

merged 12 commits into from
Jan 7, 2025

Conversation

jmezach
Copy link
Contributor

@jmezach jmezach commented Jan 6, 2025 •
edited
Loading

This refactors the way the attachments endpoint interacts with storage engines by introducing an AttachmentStorageEngine interface. It then implements that interface for all existing storage engine types (database, filesystem, s3) and adds a new implementation for storing attachments in Azure Blob Storage.

Fixes #136

Signed-off-by: Jonathan Mezach [email protected]

@jmezach jmezach mentioned this pull request Jan 6, 2025
Closed
@jmezach
Copy link
Contributor Author

jmezach commented Jan 6, 2025

I have tested that the database storage engine still works as expected. Haven't tried the filesystem one yet, nor the s3 one since I don't have access to an S3 account ;).

drodil
drodil reviewed Jan 6, 2025
View reviewed changes
Copy link
Owner

@drodil drodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just couple of small details to staighten out

plugins/qeta-backend/src/service/upload/attachmentStorageEngine.ts Outdated Show resolved Hide resolved
plugins/qeta-backend/src/service/upload/azureBlobStorage.ts Outdated Show resolved Hide resolved
plugins/qeta-backend/src/service/upload/azureBlobStorage.ts Outdated Show resolved Hide resolved
plugins/qeta-backend/src/service/upload/azureBlobStorage.ts Show resolved Hide resolved
plugins/qeta-backend/src/service/upload/azureBlobStorage.ts Show resolved Hide resolved
@drodil
Copy link
Owner

drodil commented Jan 6, 2025

Also some lint issues that need fixing. And could you update the docs/config.md as well, thanks!

jmezach added 5 commits January 6, 2025 16:18
@jmezach
Fix lint issue
df6f5e5 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Return 404 if attachment no longer exists in storage
5dd548e 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Make binaryImage undefined for Azure Blob and S3 storage
0370980 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Fix lint issues for real now
88b2a70 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Update docs
7a5ae04 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Copy link
Contributor Author

jmezach commented Jan 7, 2025

@drodil I think the lint issues are fixed now and I've updated the docs with the new configuration values.

jmezach added 2 commits January 7, 2025 11:48
@jmezach
Store user how uploaded attachment
67d412e 
Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Fix more linting things
0f564a7 
Signed-off-by: Jonathan Mezach <[email protected]>
@drodil
Copy link
Owner

drodil commented Jan 7, 2025

Looking good, going to merge and publish a new version!

@drodil drodil merged commit c46f843 into drodil:main Jan 7, 2025
6 checks passed
@jmezach jmezach deleted the feature/az-blob-storage branch January 7, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodil drodil drodil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Azure Blob Storage attachment support
2 participants
@jmezach @drodil