-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add md5 hash property to GSPath #483
Add md5 hash property to GSPath #483
Conversation
…operty inside GSPath
… like the etag property
Thanks @fafnirZ! Could you CI failures and add a new test? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 483-local-tests #483 +/- ##
=================================================
- Coverage 94.4% 93.1% -1.4%
=================================================
Files 23 23
Lines 1776 1785 +9
=================================================
- Hits 1678 1663 -15
- Misses 98 122 +24
|
Hey @pjbull, I'm kinda confused as to why my changes has caused so many seemingly unrelated tests to fail on the live server, any chance you could point me in the right direction? |
Sorry, as noted here, those are expected since PRs from forks can't access the credentials: |
Thanks for the response! Lmk if there are any issues with this PR! :) |
* Add md5 hash property to GSPath (#483) * feat: added md5_hash property in GSClient._get_metadata, added md5 property inside GSPath * docs: update supported methods and properties table in root README * chore: running make format * feat: updating code since linter wouldnt let me do it all in one line like the etag property * chore: rename variable to match the variable naming in GSPath.stat() * feat: update LocalGSPath to mimic local/implementations/azure.py for md5 property * feat: updating MockBlob to include md5_hash property * docs: updated history.md * chore: reverting to pre PEP604 syntax * test: added md5 test case, update MockBlob to take its value from an environment variable * chore: applying format and lint * Fix tests for md5 hash --------- Co-authored-by: Jacky Xie <[email protected]>
Adding md5 property into GSPath
Updating supported methods and properties in repository root README
Updating LocalGSPath to mimic LocalAzureBlobPath, in that there exists md5 property
Updating mock_gs.MockBlob to include md5_hash property
Closes #482
Contributor checklist:
CONTRIBUTING.md
Closes #issue
appears in the PR summary (e.g.,Closes #123
).HISTORY.md
with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.