Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added debug dockerfiles that support opening a terminal #143

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added debug dockerfiles that support opening a terminal #143

wants to merge 7 commits into from

Conversation

ruokun-niu
Copy link
Contributor

Description

  • Added a new Dockerfile variant called Dockerfile.debug for all variants, which uses ubuntu as the final stage image.
  • The debug images can be built with the make command make docker-build-debug

Type of change

  • This pull request fixes a bug in Drasi and has an approved issue (issue link required).
  • This pull request adds or changes features of Drasi and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Drasi (issue link optional).

Fixes: #issue_number

@ruokun-niu ruokun-niu requested a review from a team as a code owner January 23, 2025 23:13
@ruokun-niu ruokun-niu marked this pull request as draft January 23, 2025 23:19
@ruokun-niu ruokun-niu marked this pull request as ready for review January 25, 2025 06:28
amansinghoriginal
amansinghoriginal approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@amansinghoriginal amansinghoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amansinghoriginal amansinghoriginal amansinghoriginal approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruokun-niu @amansinghoriginal