Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pytest): Save into S3 temp directory #4806

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/dragonfly/snapshot_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,20 +366,20 @@ async def test_s3_snapshot(async_client, tmp_dir):
reason="AWS S3 snapshots bucket is not configured",
)
@dfly_args({**BASIC_ARGS})
async def test_s3_save_local_dir(async_client):
async def test_s3_save_local_dir(async_client, tmp_dir):
seeder = StaticSeeder(key_target=10_000)
await seeder.run(async_client)

try:
# SAVE to S3 bucket with `s3_dump` as filename prefix
await async_client.execute_command(
"SAVE", "DF", "s3://" + os.environ["DRAGONFLY_S3_BUCKET"], "s3_dump"
"SAVE", "DF", "s3://" + os.environ["DRAGONFLY_S3_BUCKET"] + str(tmp_dir), "s3_dump"
)

finally:
delete_s3_objects(
os.environ["DRAGONFLY_S3_BUCKET"],
"s3_dump",
str(tmp_dir)[1:] + "/s3_dump",
)


Expand Down
Loading