feat: ignore managed_service_info flag for cluster #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
ignore_managed_service_info_for_cluster
branch
from
06ff9fa to
60f86d1
Compare
|
@adiholden maybe we need to change our behavior a little for privilege connection and show all replicas independently on their health status? |
adiholden
reviewed
Mar 20, 2025
| @@ -68,7 +68,7 @@ ClusterShardInfos GetConfigForStats(ConnectionContext* cntx) { | |||
| CHECK(ClusterConfig::Current() != nullptr); | |||
|
|
|||
| auto config = ClusterConfig::Current()->GetConfig(); | |||
| if (cntx->conn()->IsPrivileged() || !absl::GetFlag(FLAGS_managed_service_info)) { | |||
There was a problem hiding this comment.
So when community users run dragonfly, this flag is false by default.
In this case cluster node we will not expose the replicas? why?
There was a problem hiding this comment.
it will expose replicas only for admin connections
There was a problem hiding this comment.
As I understand we want to ignore this flag
There was a problem hiding this comment.
but why do you want to expose replicas only for admin connections for community?
This is not the expected behaviour for community running dragonfly cluster
BorysTheDev
force-pushed
the
ignore_managed_service_info_for_cluster
branch
from
f398cf8 to
266ef41
Compare
adiholden
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
managed_service_info is ignored for the cluster because we have "hidden" health status for the replica