Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test new mimalloc version #4800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −13
Open

chore: test new mimalloc version #4800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9e9eb
chore: test new mimalloc version
romange Mar 20, 2025
40e54b7
chore: fixes
romange Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helio
Open in desktop
Submodule helio updated 5 files
+9 −5 base/malloc_test.cc
+2 −2 cmake/third_party.cmake
+79 −0 patches/mimalloc-v2.2.2.patch
+0 −5 util/fibers/synchronization.cc
+1 −6 util/fibers/synchronization.h
1 change: 1 addition & 0 deletions src/server/dfly_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,7 @@ Usage: dragonfly [FLAGS]
mi_option_enable(mi_option_show_errors);
mi_option_set(mi_option_max_warnings, 0);
mi_option_enable(mi_option_purge_decommits);
mi_option_set(mi_option_purge_delay, 0);

fb2::SetDefaultStackResource(&fb2::std_malloc_resource, kFiberDefaultStackSize);

Expand Down
2 changes: 1 addition & 1 deletion src/server/memory_cmd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ void MemoryCmd::ArenaStats(CmdArgList args) {
}

if (show_arenas) {
mi_debug_show_arenas(true, true, true);
mi_debug_show_arenas();
return builder_->SendOk();
}

Expand Down
3 changes: 1 addition & 2 deletions tests/dragonfly/replication_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2088,7 +2088,6 @@ async def test_policy_based_eviction_propagation(df_factory, df_seeder_factory):
proactor_threads=2,
cache_mode="true",
maxmemory="512mb",
logtostdout="true",
enable_heartbeat_eviction="false",
rss_oom_deny_ratio=1.3,
)
Expand All @@ -2098,7 +2097,7 @@ async def test_policy_based_eviction_propagation(df_factory, df_seeder_factory):
c_master = master.client()
c_replica = replica.client()

await c_master.execute_command("DEBUG POPULATE 6000 size 88000")
await c_master.execute_command("DEBUG POPULATE 6000 size 89000")

await c_replica.execute_command(f"REPLICAOF localhost {master.port}")
await wait_available_async(c_replica)
Expand Down
12 changes: 3 additions & 9 deletions tests/dragonfly/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
async-timeout==4.0.3
attrs==22.1.0
Deprecated==1.2.13
iniconfig==1.1.1
packaging==23.1
pluggy==1.0.0
py==1.11.0
pyparsing==3.0.9
packaging>=23.1
pytest==7.1.2
redis==5.2.1
tomli==2.0.1
Expand All @@ -18,9 +12,9 @@ prometheus_client==0.17.0
aiohttp==3.10.2
numpy
pytest-json-report==1.5.0
psutil==5.9.5
psutil>=5.9.5
boto3==1.28.55
redis-om==0.3.3
redis-om>=0.3.3
pytest-emoji==0.2.0
pytest-icdiff==0.8
pytest-timeout==2.2.0
Expand Down
Loading