fix: support dump for external objects #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: the code crashed on check-fail if a dump of the external string was requested. This PR fixes it. We call SerializerBase::DumpObject also in CmdSerializer::SerializeRestore, and there we also do not handle the external strings, which will be fixed in the future. Signed-off-by: Roman Gershman <[email protected]>
adiholden
reviewed
Mar 18, 2025
| CompactObj co(future.Get()); | ||
| SerializerBase::DumpObject(co, &sink); | ||
| } else { | ||
| SerializerBase::DumpObject(it->second, &sink); |
There was a problem hiding this comment.
What is this cool thingy I dont remember this...
There was a problem hiding this comment.
it is very cool, actually. When we offload an object we may still keep it in-memory so if we hit it later, we can warm it up without hitting disk by moving it from the cool storage. Cool storage is just a FIFO queue of items and if we become low on memory we start discarding the oldest ones, making the values fully external.
adiholden
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: the code crashed on check-fail if a dump of the external string was requested.
This PR fixes it.
We call SerializerBase::DumpObject also in CmdSerializer::SerializeRestore,
and there we also do not handle the external strings, which will be fixed
in the future.
Signed-off-by: Roman Gershman [email protected]