feat test: add test for pipeline queue overlimit #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
kostasrim
reviewed
Mar 17, 2025
| @@ -1159,6 +1159,32 @@ async def push_pipeline(bad_actor_client, size=1): | |||
| assert info["dispatch_queue_bytes"] == 0 | |||
|
|
|||
|
|
|||
| @dfly_args({"proactor_threads": 4, "pipeline_queue_limit": 100}) | |||
| async def test_pipeline_overlimit(df_factory: DflyInstanceFactory): | |||
There was a problem hiding this comment.
This crashes without #4789 right ?
There was a problem hiding this comment.
crashes on my laptop, I am trying to see if I see crash in github also
There was a problem hiding this comment.
Ok it does not fail on github, but it fails constantly on my laptop.
I believe this is because the slowness of the github machine.
I suggest to just add this test as it
Signed-off-by: adi_holden <[email protected]>
kostasrim
approved these changes
Mar 18, 2025
romange
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test for #4790