fix(stream_family): Fix memory tracking for the STREAMs. SECOND PR #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes dragonflydb#4725 Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
kostasrim
reviewed
Mar 17, 2025
| // the tracker will report a negative net (since we deallocated), | ||
| // so the object now consumes less memory than it did before. This DCHECK | ||
| // is for fanity and to catch any potential issues with our tracking approach. | ||
| u_.r_obj.SetSize(UpdateSize(u_.r_obj.Size(), size)); |
There was a problem hiding this comment.
This is the only functional difference from the other PR. Consider merging them into one if this is just a single line
There was a problem hiding this comment.
Let's merge the PR for JSON first because I see that the fakeredis tests are failing. It might take some time to understand what the bug is. And then maybe we will need to fix stream memory tracking in other places to pass the tests
There was a problem hiding this comment.
no issue with that -- whatever is more convenient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is described in the first PR: #4777