fix(helm): truncate metrics service name to comply with DNS naming spec #299
Conversation
Signed-off-by: Matthias Mai <[email protected]>
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v1 | |||
| kind: Service | |||
| metadata: | |||
| name: {{ include "dragonfly-operator.fullname" . }}-controller-manager-metrics-service | |||
| name: {{ include "dragonfly-operator.metricsServiceName" . }} | |||
There was a problem hiding this comment.
Instead of truncating it to the first 28 characters, I'd refer simplifying the name alltogether.
How about just fullname-controller-service or just fullname-controller-svc?
There was a problem hiding this comment.
Sure, we can do that, but the fullname will still get generated from the release name the user chooses, so there's always a chance that it will be too long and needs to be truncated. A shorter suffix won't change that, just make it less likely.
I chose to truncate the fullname to keep the suffix intact, but we could also just truncate at the end.
Unless you want to define a hardcoded name? That would cause issues if a user decides to have two helm releases in the same namespace for some reason
There was a problem hiding this comment.
maybe truncate what the user passes to a specific size and then have the controller-svc suffix?
- shorten service name suffix - rename helper to match new suffix
This pull request includes changes to the Helm chart to ensure compliance with DNS naming specifications.
metricsServiceNameto truncate the fullname template to 28 characters and append a suffix, ensuring the total length does not exceed 63 characters. (charts/dragonfly-operator/templates/_helpers.tpl)service.yamlto use the newmetricsServiceNametemplate. (charts/dragonfly-operator/templates/service.yaml)fixes #298