Let's upsell doublecmd

.github/generate_release_notes.sh

@@ -0,0 +1,57 @@
+#!/bin/bash
+# Builds the GitHub Release description: one row per plugin actually
+# packaged by build.sh, with its toolkit(s) and a link to its README.md
+# (pinned to this release's tag so the link doesn't drift as the plugin
+# changes on master later) when one exists.
+#
+# Usage: generate_release_notes.sh <repo "owner/name"> <tag> > notes.md
+
+set -euo pipefail
+REPO="$1"
+TAG="$2"
+
+readme_link() {
+    local path="$1"
+    if [ -f "$path/README.md" ]; then
+        echo "[README](https://github.com/$REPO/blob/$TAG/$path/README.md)"
+    else
+        echo "—"
+    fi
+}
+
+row() {
+    local path="$1" toolkit="$2" description="$3"
+    printf '| %s | %s | %s | %s |\n' "$(basename "$path")" "$toolkit" "$description" "$(readme_link "$path")"
+}
+
+echo "## Plugins in this release"
+echo
+echo "| Plugin | Toolkit | What it does | Docs |"
+echo "|---|---|---|---|"
+row wcx/diskdir       "Lazarus/FPC"      "Disk usage/free-space info column"
+row wdx/crx_wdx       "Rust"             "Chrome extension (.crx) metadata"
+row wdx/exif          "Lazarus/FPC"      "EXIF metadata for images"
+row wdx/ooinfo        "Lazarus/FPC"      "OpenOffice document info"
+row wdx/ooxml         "Lazarus/FPC"      "Office Open XML document info"
+row wdx/similarity    "Lazarus/FPC"      "File similarity / near-duplicate detection"
+row wdx/xpi_wdx       "Lazarus/FPC"      "Firefox extension (.xpi) metadata"
+row wdx/mediainfo     "Lua"              "Media file metadata via mediainfo CLI"
+row wdx/translitwdx   "Lua"              "Cyrillic transliteration"
+row wfx/gvfs          "Lazarus/FPC"      "Browse GVFS network filesystems"
+row wfx/rclone        "Lazarus/FPC"      "Browse rclone cloud storage remotes"
+row wlx/gstplayer     "GTK2 + GStreamer" "Simple media player in Quick View"
+row wlx/fileinfo      "Shell script"     "File info via command-line utilities"
+row wlx/csvview       "GTK3 + Qt6"       "CSV/TSV spreadsheet-like grid viewer/editor"
+row wlx/dbview        "GTK3 + Qt6"       "Multi-engine DB viewer/editor (SQLite, DuckDB, LMDB, ...)"
+row wlx/structview    "GTK3 + Qt6"       "JSON/XML/INI structured text viewer/editor"
+row wlx/sourceview    "GTK3 only"        "Text editor with syntax highlighting"
+row wlx/kpartview     "Qt6 + KDE Frameworks 6" "Universal KDE KParts host (Okular, etc.)"
+row wlx/officeview    "GTK3 + Qt6"       "MS Office / OpenDocument file preview"
+row wlx/logview       "GTK3 + Qt6"       "Large log file viewer with search/filter"
+row wlx/mpv_wayland   "GTK3 + Qt6"       "Video playback via libmpv"
+row wlx/kate          "Qt6 + KDE Frameworks 6" "Text editor with syntax highlighting"
+row wlx/diagramview   "GTK3 + Qt6"       "Mermaid/PlantUML diagram viewer"
+row wlx/mdk           "GTK3 + Qt6"       "Multimedia preview via MDK SDK"
+row wlx/markdownview  "GTK3 + Qt6"       "Rich Markdown preview"
+echo
+echo "Each plugin is packaged as its own zip below -- grab only the ones you need."

.github/workflows/release.yml

@@ -1,34 +1,125 @@
 name: build-release
 
 on:
+  # `release` events don't reliably reach Actions on a forked repo (this repo
+  # is a fork of doublecmd/plugins) -- confirmed empirically: two published
+  # releases here, zero release-triggered runs. workflow_dispatch is the
+  # trigger that's actually confirmed to work, so it takes an optional tag
+  # input: leave blank for a plain build-only smoke test, or fill in an
+  # existing release's tag to also upload zips + set its release notes.
   workflow_dispatch:
+    inputs:
+      release_tag:
+        description: "Existing release tag to upload zips to (leave blank to just build)"
+        required: false
+        type: string
   release:
-    types: [released]
+    # "released" alone excludes pre-releases -- also listen for
+    # "prereleased" since you mark early builds as pre-release. Kept even
+    # though it isn't currently firing, in case GitHub's fork behavior here
+    # changes or this repo stops being treated as a fork.
+    types: [released, prereleased]
 
 concurrency:
   group: ${{ github.ref }}
   cancel-in-progress: true
 
+permissions:
+  contents: write
+
 jobs:
   build-lin:
-    runs-on: ubuntu-22.04
+    # noble (24.04), not jammy (22.04): the Qt6/KDE Frameworks 6 plugins
+    # (csvview, dbview, diagramview, kpartview, kate, logview, markdownview,
+    # mdk, mpv_wayland, officeview, structview) need apt packages that
+    # jammy's repos don't carry at all.
+    runs-on: ubuntu-24.04
     steps:
     - name: Install Lazarus
-      run: sudo apt install lazarus
+      run: sudo apt install -y lazarus
+
+    - name: Install GTK2 library (legacy Pascal/Lazarus plugins)
+      run: sudo apt install -y libgtk2.0-dev libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
+
+    - name: Install base build tooling (CMake-based plugins)
+      run: sudo apt install -y build-essential cmake ninja-build meson pkg-config git curl wget zlib1g-dev libssl-dev zip
+
+    - name: Install GTK3 + its plugin-specific dependencies
+      run: |
+        sudo apt install -y \
+          libgtk-3-dev \
+          libwebkit2gtk-4.1-dev \
+          libcairomm-1.0-dev \
+          libpangomm-1.4-dev \
+          libfreetype-dev \
+          libfontconfig-dev \
+          librsvg2-dev \
+          libepoxy-dev \
+          libmpv-dev \
+          libxml2-dev
+
+    # qt6-base-dev already ships the QtOpenGLWidgets/QtPrintSupport headers on
+    # noble -- there's no separate -dev package for those modules, only
+    # runtime libqt6*t64 packages, which qt6-base-dev pulls in as deps anyway.
+    - name: Install Qt6 + its plugin-specific dependencies
+      run: |
+        sudo apt install -y \
+          qt6-base-dev \
+          qt6-base-dev-tools \
+          qt6-svg-dev \
+          libqt6opengl6-dev
+
+    - name: Install structview's yaml-cpp dependency
+      run: sudo apt install -y libyaml-cpp-dev
+
+    # Best-effort: KDE Frameworks 6 packaging on a given Ubuntu release can
+    # lag behind Qt6 itself. If these aren't available, kpartview and kate
+    # (the only two plugins that need them) are skipped further down via
+    # `cmake --build . --target <name> || true` rather than failing the
+    # whole workflow.
+    - name: Install KDE Frameworks 6 (kpartview, kate) - best effort
+      continue-on-error: true
+      run: |
+        sudo apt install -y \
+          extra-cmake-modules \
+          libkf6parts-dev \
+          libkf6kio-dev \
+          libkf6coreaddons-dev \
+          libkf6xmlgui-dev \
+          libkf6texteditor-dev \
+          libkf6config-dev
 
-    - name: Install GTK library 
-      run: sudo apt install libgtk2.0-dev libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
-
     - name: Checkout source
       uses: actions/checkout@v2
 
     - name: Build packages
       run: ./build.sh
 
+    # Resolves to the release tag whichever way we got triggered: the real
+    # tag on a `release` event, or whatever was typed into the manual
+    # workflow_dispatch input. Empty on a plain build-only dispatch run.
+    - name: Determine target release tag
+      id: target
+      run: |
+        if [ "${{ github.event_name }}" = "release" ]; then
+          echo "tag=${{ github.ref_name }}" >> "$GITHUB_OUTPUT"
+        else
+          echo "tag=${{ inputs.release_tag }}" >> "$GITHUB_OUTPUT"
+        fi
+
     - name: Upload binaries to release
+      if: steps.target.outputs.tag != ''
       uses: svenstaro/upload-release-action@v2
       with:
-        file: plugins-*.tar.gz
-        tag: ${{ github.ref }}
+        file: "*.zip"
+        tag: ${{ steps.target.outputs.tag }}
         overwrite: true
         file_glob: true
+
+    - name: Set release notes (plugin list, toolkit, docs links)
+      if: steps.target.outputs.tag != ''
+      env:
+        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
+        ./.github/generate_release_notes.sh "$GITHUB_REPOSITORY" "${{ steps.target.outputs.tag }}" > /tmp/notes.md
+        gh release edit "${{ steps.target.outputs.tag }}" --notes-file /tmp/notes.md

.gitmodules

@@ -0,0 +1,4 @@
+[submodule "plugin-platform"]
+	path = plugin-platform
+	url = https://github.com/pplupo/doublecmd_plugins
+	branch = plugin-platform

RELEASE_AUDIT.md

@@ -0,0 +1,32 @@
+# Release v0.01 zip audit (2026-08-26)
+
+Every zip attached to [v0.01](https://github.com/pplupo/doublecmd_plugins/releases/tag/v0.01)
+was downloaded and listed with `unzip -l` (no extraction) to check whether it actually
+contains its plugin binary. Root causes below were found in the build run's log
+(`gh run view 32974297597 --repo pplupo/doublecmd_plugins --log`).
+
+**All five gaps below have since been fixed** (in the commit that added this note) and
+verified with a real local build of each plugin. `v0.01`'s zips still reflect the broken
+state described here until the workflow is re-run against that tag.
+
+## Zips that were missing their plugin binary (now fixed)
+
+| Zip | Contained | Root cause | Fix |
+|---|---|---|---|
+| `exif` | only `README.txt`, `license.txt`, `exif.lng` — no `exif.wdx` | Compile error: `exif.c:292: error: conflicting types for 'strlcpy'`. Ubuntu 24.04's glibc now declares `strlcpy` itself, which conflicted with the plugin's own private helper of the same name. | Renamed the plugin's helper to `exif_strlcpy` throughout `exif.c`. Verified with a direct `gcc -c` compile. |
+| `rclone` | only `rclone.ico`, `COPYING.txt` — no `rclone.wfx` | Two separate bugs: (1) `rclone.lpi`'s `IncludeFiles`/`OtherUnitFiles` pointed `..\..\..\..\sdk` — one `..` too many, resolving outside the repo entirely instead of to `sdk/`. (2) Once that was fixed, a second real error surfaced: `FsExtractCustomIconW`'s `TheIcon: PWfxIcon` parameter type doesn't exist in this repo's `sdk/wfxplugin.pas`, which only has the older `var TheIcon: hicon` icon-extraction signature — the code was written against a newer WFX SDK than what's vendored here. | Fixed the include path to `..\..\..\sdk` (3 levels). Changed the signature to `var TheIcon: hicon` and simplified the body to always return `FS_ICON_USEDEFAULT` (the plugin never had working icon-loading code to produce a real `hicon` handle, so it now explicitly defers to DC's default icon instead of a struct-typed dead end). Verified with a full `lazbuild --build-mode=Release` producing `rclone.wfx`. |
+| `officeview` | only `README.md` — no `officeview_qt6.wlx`/`officeview_gtk3.wlx` | `CMake Error: The current CMakeCache.txt directory ... is different than the directory ... where CMakeCache.txt was created.` **Cause: `wlx/officeview/build/CMakeCache.txt` was committed to git**, baked with an absolute path from a local dev machine (`/home/pplupo/repos/plugins/...`). When CI checked out the repo, that stale cache collided with the runner's own checkout path and CMake refused to proceed. Confirmed via `git ls-files` that `wlx/officeview/build/` was the only plugin's build dir with `CMakeCache.txt` actually tracked (other plugins had stray tracked files under `build/` too, but not their `CMakeCache.txt`, so they didn't hit this exact failure). | `git rm -r --cached` on every tracked `build/` directory repo-wide (`wlx/csvview`, `wlx/kate`, `wlx/kpartview`, `wlx/officeview`, `wlx/structview`, `wlx/wayland_qt_base`, `wfx/rclone` — 763 tracked files total) and added/extended a `build/` `.gitignore` entry in each of those plugin dirs. |
+| `logview` | only `README.md`, `logviewer.png`, `color_editor.png`, a stray `double commander wlx log viewer.md` — no `logviewer.wlx` | Compile error: `LogViewerWidget.cpp:398: error: 'beginFilterChange' was not declared in this scope` (and 3 more of the same). `QSortFilterProxyModel::beginFilterChange()`/`endFilterChange()` are Qt 6.7+ API; `ubuntu-24.04`'s `qt6-base-dev` ships Qt 6.4.2. | Replaced all four `beginFilterChange()`/`endFilterChange()` pairs with `invalidateFilter()`, the pre-6.7 equivalent. Verified with a full CMake build in the same GTK3/Qt6 dev container used throughout this project (Qt 6.4.2), producing `logviewer.wlx`. |
+| `mdk` | only `proposal.md`, `README.md` — no `mdk_qt6.wlx` | `fatal error: mdk/c/Player.h: No such file or directory`. The MDK SDK (`https://github.com/wang-bin/mdk-sdk`) is a third-party SDK `mdk_core` needs only the **headers** from at compile time (`libmdk.so` itself is `dlopen()`'d at runtime, see `MdkEngine.cpp`); it isn't an apt package and CI never fetched it. | `wlx/mdk/CMakeLists.txt` now uses `FetchContent` to download the pinned `mdk-sdk-linux-x64.tar.xz` v0.38.0 release tarball (SHA256-verified) and points `MDK_SDK_INCLUDE` at its `include/` dir, but only when a local `~/mdk-sdk/include` isn't already present (a dev's own manual SDK install still takes priority). Verified with a full CMake build (forcing the fetch path via `-DMDK_SDK_INCLUDE=/nonexistent`), producing `mdk_qt6.wlx`. |
+
+## Confirmed correct (zip contains its plugin binary)
+
+`crx_wdx`, `csvview` (both `_gtk3`/`_qt6`), `dbview` (both), `diagramview` (both), `diskdir`,
+`fileinfo`, `gstplayer`, `gvfs`, `kate`, `kpartview`, `markdownview` (both),
+`mpv_wayland` (both), `ooinfo`, `ooxml`, `similarity`, `sourceview`, `structview` (both),
+`xpi_wdx`.
+
+## Correctly binary-less (not a bug)
+
+`mediainfo` and `translitwdx` are Lua scripts run by a Lua-hosting plugin, not
+compiled `.wdx` binaries — their zips containing only `.lua`/text files is expected.