ItemsCommands #8200
Open
ItemsCommands #8200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new feature introducing built-in set of commands applicable to collection(view) of items.
This will enable controls to implement sorting and grouping using commands, and specifically allow
DataGridto sustainably handle sorting using keyboard instead of #6873.This PR implements API proposal #8199.
Customer Impact
Without taking this PR, developers will need to create custom solutions to for invoking sorting and grouping. These can be user-defined commands, however, these would not be available to built-in controls shipping with WPF.
Regression
No.
Testing
Compiled and tested with 8.0.100-preview.7.23376.3, that the commands can be parsed from XAML, bound to keyboard shortcuts and executed on various targets using explicit buttons as well as shortcuts, including modified DataGrid.
Risk
Theis is a new class with static members not affecting any existing functionality.
Microsoft Reviewers: Open in CodeFlow