Skip to content

make TriggerBase to "public" #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sjtao-online
Copy link

@sjtao-online sjtao-online commented Jan 28, 2023

Allows users to create custom triggers
I wanted to create a particular trigger, but GetCurrentState in TriggerBase and Trigger is internal and causes invisibility.
So submit this PR, which is very useful when writing custom frameworks

from [Bing Microsoft Translator]

Microsoft Reviewers: Open in CodeFlow

Allows users to create custom triggers
@sjtao-online sjtao-online requested a review from a team as a code owner January 28, 2023 03:23
@ghost ghost assigned sjtao-online Jan 28, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 28, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf January 28, 2023 03:23
@dnfadmin
Copy link

dnfadmin commented Jan 28, 2023

CLA assistant check
All CLA requirements met.

@ghost ghost added the Community Contribution A label for all community Contributions label Jan 28, 2023
@lindexi
Copy link
Member

lindexi commented Jan 28, 2023

Thank you @sjtao-online . But I think this change is worth discussing

@sjtao-online
Copy link
Author

Thank you @sjtao-online . But I think this change is worth discussing

在写复杂控件或框架时如有更复杂的Trigger肯定事半功能倍 例如Trigger间或关系,例如Trigger与DataTrigger之间的且等等

@lindexi
Copy link
Member

lindexi commented Jan 28, 2023

@sjtao-online I means that the PR may be merged for a long time.

我意思是这个代码可能会被挂很久...

@sjtao-online
Copy link
Author

@sjtao-online I means that the PR may be merged for a long time.

我意思是这个代码可能会被挂很久...

这个我倒是想到了,毕竟现在WPF也不是首推了,而且这样的改动确实可能存在被滥用的可能性。
哎,每次看到都想,这次就提了,尽人事听天命呗。
另外谢谢您的回复

@lindexi
Copy link
Member

lindexi commented Jan 28, 2023

@sjtao-online 按照他这个体量,随便修改 API 会被喷的,现在都谨慎的不行了。上回只是稍微动了一下行为,如我博客记录的 dotnet 7 的改动,就被大佬们喷了一顿,乖乖在 dotnet 8 加开关

现在改一个 API 都需要很多的评估

@sjtao-online
Copy link
Author

@sjtao-online 按照他这个体量,随便修改 API 会被喷的,现在都谨慎的不行了。上回只是稍微动了一下行为,如我博客记录的 dotnet 7 的改动,就被大佬们喷了一顿,乖乖在 dotnet 8 加开关

现在改一个 API 都需要很多的评估

确实如此,船大呀,现在的WPF应该是MS自己的市面上C端用的最多的了,一点点改动都会有很大影响,WinUI3里很多改动感觉随意很多,不过大部分还是很保守的,能感觉出来。
但依然希望能把原来一些不能被继承修改的权限放出来,不想用的继续用原来的,有想法的可能更自由一些,这里的其实也是这么个意思,所以并没有任何逻辑代码改动,保是调整了权限关系使得自己重定义成为可能。

@miloush
Copy link
Contributor

miloush commented Feb 16, 2023

Keeping the conversation in English would allow more people to participate.

Please use the PR template that includes testing and risk assessment.

This PR exposes internal implementation details such us UncommonField that should not become public. It does not even build.

@sjtao-online
Copy link
Author

Keeping the conversation in English would allow more people to participate.

Please use the PR template that includes testing and risk assessment.

This PR exposes internal implementation details such us that should not become public. It does not even build.UncommonField

I know this, I just wanted to offer an idea, but I'm a Chinese who only uses Chinese when I know that the discussion is also Chinese.
from [Bing Microsoft Translator]
我知道这些,我只是想提供一个想法(也并没有想过会成功,我更多是使用者),但我是一个中国人,在知道讨论也是中国人时才使用的中文。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Requested Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants