-
Notifications
You must be signed in to change notification settings - Fork 1.2k
make TriggerBase to "public" #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allows users to create custom triggers
Thank you @sjtao-online . But I think this change is worth discussing |
在写复杂控件或框架时如有更复杂的Trigger肯定事半功能倍 例如Trigger间或关系,例如Trigger与DataTrigger之间的且等等 |
@sjtao-online I means that the PR may be merged for a long time. 我意思是这个代码可能会被挂很久... |
这个我倒是想到了,毕竟现在WPF也不是首推了,而且这样的改动确实可能存在被滥用的可能性。 |
@sjtao-online 按照他这个体量,随便修改 API 会被喷的,现在都谨慎的不行了。上回只是稍微动了一下行为,如我博客记录的 dotnet 7 的改动,就被大佬们喷了一顿,乖乖在 dotnet 8 加开关 现在改一个 API 都需要很多的评估 |
确实如此,船大呀,现在的WPF应该是MS自己的市面上C端用的最多的了,一点点改动都会有很大影响,WinUI3里很多改动感觉随意很多,不过大部分还是很保守的,能感觉出来。 |
Keeping the conversation in English would allow more people to participate. Please use the PR template that includes testing and risk assessment. This PR exposes internal implementation details such us |
I know this, I just wanted to offer an idea, but I'm a Chinese who only uses Chinese when I know that the discussion is also Chinese. |
Allows users to create custom triggers
I wanted to create a particular trigger, but GetCurrentState in TriggerBase and Trigger is internal and causes invisibility.
So submit this PR, which is very useful when writing custom frameworks
from [Bing Microsoft Translator]
Microsoft Reviewers: Open in CodeFlow