Add NavigationService.RemoveForwardEntry #7229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
lindexi
reviewed
Oct 27, 2022
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Navigation/Journal.cs
Outdated
Show resolved
Hide resolved
|
Look good to me. Thank you @Symbai |
…ows/Navigation/Journal.cs Co-authored-by: lindexi <[email protected]>
|
Can you comment a bit on whether/how this was tested and why this is no risk? |
No risk because it doesn't affect any existing code, its a new API. Tested locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7215
Main PR
Description
There is already an API to remove the first entry from back stack. This PR allows developers to remove the first entry from forward stack. This is currently impossible.
Customer Impact
Customers can now remove items from forward stack.
Regression
No regression
Testing
Risk
No risk
Microsoft Reviewers: Open in CodeFlow